This repository has been archived by the owner on Jun 3, 2024. It is now read-only.
Checklist: rename values prop to value
#558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with a fix for a couple of broken links
byronz
reviewed
May 31, 2019
| @@ -838,7 +838,7 @@ def test_gallery(self): | |||
| {'label': 'San Francisco', 'value': 'SF'}, | |||
| {'label': u'北京', 'value': u'北京'} | |||
There was a problem hiding this comment.
we should leave an easter egg here with {'label': u'北京', 'value': u'帝都'}
There was a problem hiding this comment.
I liked your original comment - it would be an eastern egg indeed 😉 feel free to add it!
There was a problem hiding this comment.
but you might not get the egg? or you level of mandarin is beyond my imagination :)
There was a problem hiding this comment.
My mandarin is only as good as google translate's. But I have no problem with spreading the fun around to more languages - we have plenty of little English jokes scattered around our tests!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the breaking changes planned for the Dash 1.0 release.
Also a couple of little prop type & doc fixes for the
valueprop inDropdownandRadioItems.